This repository was archived by the owner on Jan 9, 2020. It is now read-only.
inherit IO to get kubectl logs output#13
Merged
mccheah merged 1 commit intok8s-support-alternate-incrementalfrom Jan 12, 2017
Merged
inherit IO to get kubectl logs output#13mccheah merged 1 commit intok8s-support-alternate-incrementalfrom
mccheah merged 1 commit intok8s-support-alternate-incrementalfrom
Conversation
Member
Author
|
Just throwing this out there. The change appears to work for me. Was there some reason why this was not considered a viable alternative? |
Member
Author
|
The biggest advantage is log streaming using |
|
Yup this is a good idea. |
7 tasks
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
ifilonenko
referenced
this pull request
in bloomberg/apache-spark-on-k8s
Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ash211 @mccheah I was thinking about the logging that we have, where we redirect output to files.
Using the container's stdout/stderr instead of redirecting to file the way we do it currently may be advantageous, because it has the logic to rotate logs, and keep 5 of the most recent ones (each 10M in size). This also allows for the use of
kubectl logsdirectly, which would be analogous toyarn logs.